Github user gtenev commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1100#discussion_r83511226
--- Diff: proxy/http2/Http2ConnectionState.cc ---
@@ -1097,6 +1141,7 @@ void
Http2ConnectionState::send_data_frames(Http2Stream *stream)
{
if (stream->get_state() == HTTP2_STREAM_STATE_CLOSED) {
+ this->delete_stream(stream);
return;
--- End diff --
No, I may have overdone it here.
I thought I would add this deletion because few lines below there is
deleting if state == `HTTP2_STREAM_STATE_CLOSED`. `send_data_frames()` is
called not only from `do_io_close()`, and calling `delete_stream()` on already
deleted stream is OK (with this change).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
