Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/1110
I think we should fix up the casts, or not. I think it's worse to say we'll
fix some of the pointless casts but not others. If the goal is to show correct
code, they should all be fixed. I also think if we're fixing this all C style
casts should be removed. Those are strongly deprecated for C++ code. The point
of the distinct casts is to make it clear what is being done.
I'm fine with splitting this into a PR for each commit. That's why I left
them separated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---