[ 
https://issues.apache.org/jira/browse/TS-4971?focusedWorklogId=30715&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30715
 ]

ASF GitHub Bot logged work on TS-4971:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Oct/16 19:40
            Start Date: 15/Oct/16 19:40
    Worklog Time Spent: 10m 
      Work Description: Github user SolidWallOfCode commented on the issue:

    https://github.com/apache/trafficserver/pull/1110
  
    I think we should fix up the casts, or not. I think it's worse to say we'll 
fix some of the pointless casts but not others. If the goal is to show correct 
code, they should all be fixed. I also think if we're fixing this all C style 
casts should be removed. Those are strongly deprecated for C++ code. The point 
of the distinct casts is to make it clear what is being done.
    
    I'm fine with splitting this into a PR for each commit. That's why I left 
them separated.


Issue Time Tracking
-------------------

    Worklog Id:     (was: 30715)
    Time Spent: 2h 50m  (was: 2h 40m)

> Change TSPluginRegistration and TSPluginRegister to take const data
> -------------------------------------------------------------------
>
>                 Key: TS-4971
>                 URL: https://issues.apache.org/jira/browse/TS-4971
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Plugins
>            Reporter: Alan M. Carroll
>             Fix For: 7.1.0
>
>          Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> These should be constant. The fact they are not causes problems and bad 
> programming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to