[
https://issues.apache.org/jira/browse/TS-4578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15589298#comment-15589298
]
Alan M. Carroll commented on TS-4578:
-------------------------------------
I don't think those functions are useful. It would be better to modify
{{ats_ip_pton}} to work like those if you pass {{nullptr}} for the {{addr}}
parameter. In this case in particular {{ats_ip_pton}} is required because the
resulting IP address is needed to connect to the origin server - this is the
source of it in this case.
> Skip HostDB lookup for all address literals
> -------------------------------------------
>
> Key: TS-4578
> URL: https://issues.apache.org/jira/browse/TS-4578
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core, DNS
> Reporter: James Peach
> Assignee: David Ben Zakai
> Labels: newbie
> Fix For: sometime
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In {{HttpSM.cc}}:
> {code}
> if ((strncmp(t_state.dns_info.lookup_name, "127.0.0.1", 9) == 0 ||
> strncmp(t_state.dns_info.lookup_name, "::1", 3) == 0) &&
> ats_ip_pton(t_state.dns_info.lookup_name, t_state.host_db_info.ip())
> == 0) {
> // If it's 127.0.0.1 or ::1 don't bother with hostdb
> DebugSM("dns", "[HttpTransact::HandleRequest] Skipping DNS lookup for
> %s because it's loopback",
> t_state.dns_info.lookup_name);
> t_state.dns_info.lookup_success = true;
> call_transact_and_set_next_state(NULL);
> break;
> {code}
> There's no reason to restrict address literals to loopback. It seems like we
> should be able to do this for all address literals.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
