[
https://issues.apache.org/jira/browse/TS-5009?focusedWorklogId=31259&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31259
]
ASF GitHub Bot logged work on TS-5009:
--------------------------------------
Author: ASF GitHub Bot
Created on: 27/Oct/16 16:44
Start Date: 27/Oct/16 16:44
Worklog Time Spent: 10m
Work Description: Github user ngara commented on the issue:
https://github.com/apache/trafficserver/pull/1152
I put the plugin hook in and got it working. Thanks for the suggestion.
Nathan
> On Oct 26, 2016, at 9:01 PM, Leif Hedstrom <notificati...@github.com>
wrote:
>
> @ngara <https://github.com/ngara> I think this is failing because of
clang-format. I recommend you copy the pre-commit githook into your .git/hooks
tree.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
<https://github.com/apache/trafficserver/pull/1152#issuecomment-256541086>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AA51eE0tGOe6QyG0UPgODLOK41L_-Xutks5q4CILgaJpZM4KhylU>.
>
Issue Time Tracking
-------------------
Worklog Id: (was: 31259)
Time Spent: 1h (was: 50m)
> CID 1022011 Logically dead code
> -------------------------------
>
> Key: TS-5009
> URL: https://issues.apache.org/jira/browse/TS-5009
> Project: Traffic Server
> Issue Type: Bug
> Components: Core
> Reporter: Nathan Garabedian
> Assignee: Nathan Garabedian
> Labels: coverity
> Fix For: 7.1.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> TS_INLINE char &IOBufferReader::operator[](int64_t i)
> 686{
> 687 static char _error = '\0';
> 688 IOBufferBlock *b = block.get();
> 689
> 690 i += start_offset;
> cond_null: Condition b, taking false branch. Now the value of b is NULL.
> 691 while (b) {
> 692 int64_t bytes = b->read_avail();
> 693 if (bytes > i)
> 694 return b->start()[i];
> 695 i -= bytes;
> 696 b = b->next.get();
> 697 }
> 698
> 699 ink_assert(!"out of range");
> const: At condition !!b, the value of b must be equal to 0.
> null: At condition !!b, the value of b must be NULL.
> dead_error_condition: The condition !!b cannot be true.
> 700 if (unlikely(b)) {
>
> CID 1022011 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: return b->start();.
> 701 return *b->start();
> 702 }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
