[ https://issues.apache.org/jira/browse/TS-4399?focusedWorklogId=31354&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31354 ]
ASF GitHub Bot logged work on TS-4399: -------------------------------------- Author: ASF GitHub Bot Created on: 01/Nov/16 03:26 Start Date: 01/Nov/16 03:26 Worklog Time Spent: 10m Work Description: Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1073#discussion_r85870674 --- Diff: mgmt/LocalManager.cc --- @@ -902,8 +907,13 @@ LocalManager::startProxy() Vec<char> real_proxy_options; real_proxy_options.append(proxy_options, strlen(proxy_options)); + if (onetime_options && *onetime_options) { + real_proxy_options.append(" ", strlen(" ")); + real_proxy_options.append(onetime_options, strlen(onetime_options)); + } - if (!strstr(proxy_options, MGMT_OPT)) { // Make sure we're starting the proxy in mgmt mode + // Make sure we're starting the proxy in mgmt mode + if (!strstr(proxy_options, MGMT_OPT) && !strstr(onetime_options, MGMT_OPT)) { --- End diff -- Prefer ``strstr(...) == 0``. It's just that little bit more readable. Issue Time Tracking ------------------- Worklog Id: (was: 31354) Time Spent: 2h (was: 1h 50m) > Management API breaks diagnostic log rotation > --------------------------------------------- > > Key: TS-4399 > URL: https://issues.apache.org/jira/browse/TS-4399 > Project: Traffic Server > Issue Type: Bug > Components: Logging, Management API > Reporter: James Peach > Assignee: Daniel Xu > Fix For: 7.1.0 > > Time Spent: 2h > Remaining Estimate: 0h > > Start up Traffic Server: > {code} > 0 26950 1 0 10:13AM ?? 0:00.01 /opt/ats/bin/traffic_cop > -2 26951 26950 0 10:13AM ?? 0:00.02 /opt/ats/bin/traffic_manager > --bind_stdout /opt/ats/var/log/trafficserver/traffic.out --bind_stderr > /opt/ats/var/log/trafficserver/traffic.out > -2 26952 26951 0 10:13AM ?? 0:00.08 /opt/ats/bin/traffic_server > -M --bind_stdout /opt/ats/var/log/trafficserver/traffic.out --bind_stderr > /opt/ats/var/log/trafficserver/traffic.out --httpport 8080:fd=12 > {code} > Now restart it using {{traffic_line -S}} followed by {{traffic_line -U}}: > {code} > 0 26950 1 0 10:13AM ?? 0:00.01 /opt/ats/bin/traffic_cop > -2 26951 26950 0 10:13AM ?? 0:00.05 /opt/ats/bin/traffic_manager > --bind_stdout /opt/ats/var/log/trafficserver/traffic.out --bind_stderr > /opt/ats/var/log/trafficserver/traffic.out > -2 26967 26951 0 10:13AM ?? 0:00.12 /opt/ats/bin/traffic_server > -M --httpport 8080:fd=20 > {code} > Note that we lost the {{\--bind_stdout}} and {{\--bind_stderr}} options. -- This message was sent by Atlassian JIRA (v6.3.4#6332)