Github user zwoop commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/1167#discussion_r85967946
  
    --- Diff: lib/cppapi/Request.cc ---
    @@ -177,6 +177,23 @@ Request::getHeaders() const
       return state_->headers_;
     }
     
    +void
    +Request::setHost(std::string const &host)
    +{
    +  static std::string HOST_FIELD_NAME(TS_MIME_FIELD_HOST, TS_MIME_LEN_HOST);
    --- End diff --
    
    < bike_shed >Shouldn't this be const too?< /bike_shed >


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to