[
https://issues.apache.org/jira/browse/TS-4728?focusedWorklogId=31828&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31828
]
ASF GitHub Bot logged work on TS-4728:
--------------------------------------
Author: ASF GitHub Bot
Created on: 08/Nov/16 23:34
Start Date: 08/Nov/16 23:34
Worklog Time Spent: 10m
Work Description: GitHub user pbchou opened a pull request:
https://github.com/apache/trafficserver/pull/1213
TS-4728 Null pointer error in LogHost.cc (backport 6.2.x)
@PSUdaemon -- As requested, this is a PR to backport the commits for this
issue to 6.2.x. However, I'm not sure that I can fully vouch for this because
IIRC the crash bug that I reported in the Jira was present in 7.0.x but not in
6.1.x or 6.2.x.
It was @zwoop who requested the back-port originally and @jpeach who wrote
the commits in this PR.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pbchou/trafficserver TS-4728-backport-6.2.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1213.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1213
----
commit e2d746871d0fc05d280e74585289a14c5570dfdd
Author: James Peach <jpe...@apache.org>
Date: 2016-08-10T21:10:17Z
TS-4728: Return bool from LogHost boolean functions.
(cherry picked from commit 0a12b2682cc718057ee33d0642dfe009c5574004)
Conflicts:
proxy/logging/LogHost.cc
commit 8ec7dcd922493ec41318c989102717b555454a68
Author: James Peach <jpe...@apache.org>
Date: 2016-08-10T21:16:16Z
TS-4728: Remove invalid LogHost assertion.
(cherry picked from commit f502718abc09c66830d9dececf596e039daec422)
Conflicts:
proxy/logging/LogHost.cc
----
Issue Time Tracking
-------------------
Worklog Id: (was: 31828)
Time Spent: 1h 40m (was: 1.5h)
> Null pointer error in LogHost.cc.
> ---------------------------------
>
> Key: TS-4728
> URL: https://issues.apache.org/jira/browse/TS-4728
> Project: Traffic Server
> Issue Type: Bug
> Components: Logging
> Affects Versions: 7.0.0
> Reporter: Peter Chou
> Assignee: James Peach
> Fix For: 7.0.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> [~jpe...@apache.org] I am getting a null pointer access error with the
> following assertion at the time of traffic_server start-up with log collation
> enabled (client-side). I was able to get around it by just commenting it out,
> but perhaps a better fix is required.
> {noformat}
> LogHost::create_orphan_LogFile_object()
> {
> // We expect that no-one else is holding any refcounts on the
> // orphan file so that is will be releases when we replace it
> // below.
> ink_assert(m_orphan_file->refcount() == 1);
> {noformat}
> Back-trace --
> {noformat}
> #0 0x000000000053e772 in RefCountObj::refcount (this=0x8) at
> ../lib/ts/Ptr.h:80
> #1 0x0000000000692f9f in LogHost::create_orphan_LogFile_object
> (this=0x2268d80) at LogHost.cc:235
> #2 0x0000000000692a45 in LogHost::set_ipstr_port (this=0x2268d80,
> ipstr=0x2265d40 "127.0.0.1", pt=8085) at LogHost.cc:135
> #3 0x0000000000692b92 in LogHost::set_name_or_ipstr (this=0x2268d80,
> name_or_ip=0x2265d40 "127.0.0.1") at LogHost.cc:155
> #4 0x0000000000684046 in LogConfig::read_xml_log_config (this=0x21e4110) at
> LogConfig.cc:1472
> #5 0x000000000067ff73 in LogConfig::setup_log_objects (this=0x21e4110) at
> LogConfig.cc:510
> #6 0x000000000067f858 in LogConfig::init (this=0x21e4110, prev_config=0x0)
> at LogConfig.cc:395
> #7 0x00000000006721fe in Log::init (flags=0) at Log.cc:925
> #8 0x0000000000542552 in main (argv=0x7ffcc853abd8) at Main.cc:1828
> {noformat}
> I made minimal changes to logs_xml.config to set as client --
> {noformat}
> <LogFormat>
> <Name = "minimal"/>
> <Format = "%<chi> : %<cqu> : %<pssc>"/>
> </LogFormat>
> <LogObject>
> <Format = "minimal"/>
> <Filename = "minimal_remote"/>
> <CollationHosts = "127.0.0.1:8085"/>
> </LogObject>
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
