Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1212#discussion_r87417967
--- Diff: iocore/net/SSLUtils.cc ---
@@ -141,8 +142,9 @@ static int ssl_vc_index = -1;
static ink_mutex *mutex_buf = nullptr;
static bool open_ssl_initialized = false;
-RecRawStatBlock *ssl_rsb = nullptr;
-static InkHashTable *ssl_cipher_name_table = nullptr;
+RecRawStatBlock *ssl_rsb = nullptr;
+typedef std::unordered_map<const char *, intptr_t> cipherTable;
--- End diff --
That's what I thought too (we provide custom hashing functions for this in
a few places), but then I tested this on a modern compiler, and it seemed to do
it right. I assume C++11 had added support for hashing the char*, but now that
you say this, it's quite possible my tests were wrong.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
