[ 
https://issues.apache.org/jira/browse/TS-5062?focusedWorklogId=32519&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-32519
 ]

ASF GitHub Bot logged work on TS-5062:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 29/Nov/16 04:30
            Start Date: 29/Nov/16 04:30
    Worklog Time Spent: 10m 
      Work Description: Github user jpeach commented on a diff in the pull 
request:

    https://github.com/apache/trafficserver/pull/1233#discussion_r89939136
  
    --- Diff: doc/developer-guide/api/functions/TSMgmtSourceGet.en.rst ---
    @@ -0,0 +1,69 @@
    +.. Licensed to the Apache Software Foundation (ASF) under one or more
    +   contributor license agreements.  See the NOTICE file distributed
    +   with this work for additional information regarding copyright
    +   ownership.  The ASF licenses this file to you under the Apache
    +   License, Version 2.0 (the "License"); you may not use this file
    +   except in compliance with the License.  You may obtain a copy of
    +   the License at
    +
    +   http://www.apache.org/licenses/LICENSE-2.0
    +
    +   Unless required by applicable law or agreed to in writing, software
    +   distributed under the License is distributed on an "AS IS" BASIS,
    +   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
    +   implied.  See the License for the specific language governing
    +   permissions and limitations under the License.
    +
    +.. include:: ../../../common.defs
    +
    +.. default-domain:: c
    +
    +TSMgmtSourceGet
    +***************
    +
    +Synopsis
    +========
    +
    +`#include <ts/ts.h>`
    +
    +.. function:: TSReturnCode TSMgmtSourceGet(const char * var_name, 
TSMgmtSource * result)
    +
    +Description
    +===========
    +
    +Get the source of a value for a configuration variable. :arg:`var_name` is 
the name of the variable
    +as a nul terminated string. The source value is stored in :arg:`result`. 
The function can return
    +failure if :arg:`var_name` is not found.
    +
    +Types
    +=====
    +
    +.. type:: TSMgmtSource
    +
    +   Source of the current value for a management (configuration) value.
    +
    +   .. macro:: TS_MGMT_SOURCE_NULL
    --- End diff --
    
    Why don't you just return this instead of `TS_ERROR`?


Issue Time Tracking
-------------------

    Worklog Id:     (was: 32519)
    Time Spent: 2.5h  (was: 2h 20m)

> traffic_ctl doesn't correctly detect plugin source for configuration variable.
> ------------------------------------------------------------------------------
>
>                 Key: TS-5062
>                 URL: https://issues.apache.org/jira/browse/TS-5062
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Management API
>            Reporter: Alan M. Carroll
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> If a plugin adds configuration variables via something like 
> `TSMgmtStringCreate` these are marked as "explicit" rather than plugin 
> provided defaults, which means the administrator can't tell if the values are 
> from the plugin or his configuration. This should be improved to be parallel 
> to core configuration values where these case are distinguishable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to