Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1252
Hmmm, it seems we are incredibly inconsistent here. Why singling out this
one place for this change? Do we really need TS_INLINE in general? I notice we
turn off inlining via #define in some places, but then I'd argue that we should
not use it at all in those place, no?
I think what I'm saying is
1) Why not remove TS_INLINE ? I.e. just use inline.
2) In those places where TS_INLINE is used, but #define'd to nothing, we
just remove TS_INLINE.
3) Maybe also make an effort to reduce the use of inline in general, and
let the compiler deal with it.
I'm fine landing this as-is in this patch, but maybe file another Jira for
a general cleanup here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
