[
https://issues.apache.org/jira/browse/TS-5053?focusedWorklogId=33415&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-33415
]
ASF GitHub Bot logged work on TS-5053:
--------------------------------------
Author: ASF GitHub Bot
Created on: 12/Dec/16 18:39
Start Date: 12/Dec/16 18:39
Worklog Time Spent: 10m
Work Description: GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/1257
TS-5053 const char **argv passed to TSPluginInit is not null terminated
Typically **argv is null terminated in other systems. There's no
good reason for ATS to be any different.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/danobi/trafficserver TS-5053
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1257.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1257
----
commit a338905c3c6dfce511c162e9a352330181fcbdc8
Author: Daniel Xu <dl...@yahoo.com>
Date: 2016-12-12T18:38:05Z
TS-5053 const char **argv passed to TSPluginInit is not null terminated
Typically **argv is null terminated in other systems. There's no
good reason for ATS to be any different.
----
Issue Time Tracking
-------------------
Worklog Id: (was: 33415)
Time Spent: 10m
Remaining Estimate: 0h
> const char **argv passed to TSPluginInit is not null terminated
> ---------------------------------------------------------------
>
> Key: TS-5053
> URL: https://issues.apache.org/jira/browse/TS-5053
> Project: Traffic Server
> Issue Type: Bug
> Components: Plugins
> Reporter: Daniel Xu
> Assignee: Daniel Xu
> Fix For: 7.1.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> See title. Typically **argv is null terminated in other systems. And who are
> we to question 1000 years of tradition?
> One example of an issue is that {{lib/ts/ink_args.cc}} actually relies on
> **argv being null terminated. Interesting segfaults occur in plugins usings
> the ATS argument parser.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
