[ 
https://issues.apache.org/jira/browse/TS-4583?focusedWorklogId=34025&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34025
 ]

ASF GitHub Bot logged work on TS-4583:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Dec/16 04:12
            Start Date: 22/Dec/16 04:12
    Worklog Time Spent: 10m 
      Work Description: Github user bryancall commented on the issue:

    https://github.com/apache/trafficserver/pull/802
  
    I think it is correct to check the value of the server_entry is not NULL 
before dereferencing the pointer in the same conditional.  This is a common 
pattern.
    
    The method release_server_session dereferences dereference server_entry, so 
it is most likely stopped by the servers_session NULL pointer check before the 
dereference.  This is more of a side effect and shouldn't be relied on.


Issue Time Tracking
-------------------

    Worklog Id:     (was: 34025)
    Time Spent: 1h 40m  (was: 1.5h)

> CID 1021958: Null-pointer dereference after check
> -------------------------------------------------
>
>                 Key: TS-4583
>                 URL: https://issues.apache.org/jira/browse/TS-4583
>             Project: Traffic Server
>          Issue Type: Bug
>            Reporter: Jari Alhonen
>            Assignee: Jari Alhonen
>             Fix For: 7.1.0
>
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> HttpSM.cc checks server_entry against NULL, suggesting it might be NULL, 
> before calling release_server_session(), which dereferences server_entry.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to