GitHub user zwoop opened an issue:

    https://github.com/apache/trafficserver/issues/1283

    CID 1367526:  CID 1367525 : money_trace/money_trace.cc

    ```
    *** CID 1367526:  Null pointer dereferences  (REVERSE_INULL)
    /plugins/experimental/money_trace/money_trace.cc: 57 in 
freeTransactionData(txndata *)()
    51         TSfree(txn_data->client_request_mt_header);
    52       }
    53       if (txn_data->new_span_mt_header != NULL) {
    54         LOG_DEBUG("freeing txn_data->new_span_mt_header.");
    55         TSfree(txn_data->new_span_mt_header);
    56       }
       CID 1367526:  Null pointer dereferences  (REVERSE_INULL)
       Null-checking "txn_data" suggests that it may be null, but it has 
already been dereferenced on all paths leading to the check.
    57       if (txn_data != NULL) {
    58         LOG_DEBUG("freeing txn_data.");
    59         TSfree(txn_data);
    60       }
    61     }
    62     
    ```
    
    and
    
    ```
    *** CID 1367525:  Resource leaks  (RESOURCE_LEAK)
    /plugins/experimental/money_trace/money_trace.cc: 147 in 
mt_check_request_header(tsapi_httptxn *)()
    141           LOG_DEBUG("no money trace header was found in the request.");
    142         }
    143       } else {
    144         LOG_DEBUG("failed to retrieve the client request.");
    145       }
    146       TSHandleMLocRelease(bufp, hdr_loc, field_loc);
       CID 1367525:  Resource leaks  (RESOURCE_LEAK)
       Variable "txn_data" going out of scope leaks the storage it points to.
    147     }
    148     
    149     /**
    150      * The TS_EVENT_HTTP_SEND_RESPONSE_HDR callback.
    151      *
    152      * Adds the money trace header received in the client request to the
    
    ```

----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to