[
https://issues.apache.org/jira/browse/TS-5107?focusedWorklogId=34988&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34988
]
ASF GitHub Bot logged work on TS-5107:
--------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jan/17 15:35
Start Date: 08/Jan/17 15:35
Worklog Time Spent: 10m
Work Description: Github user jbfavre commented on the issue:
https://github.com/apache/trafficserver/pull/1303
Well, at least I won't go against it :)
When fixing it in first place, docutils devs feedback was that we wrongly
used Inliner, in the sense it's supposed to be internal.
What if another docutils internal change breaks it again ? Don't think it
won't happen because the discussion I had showed that not every docutils dev is
happy with last change. So, chances are that there'll be another refacto, maybe
for 0.15 or 0.16.
Better solution, in both docutils devs & myself, should be to make Sphinx
allow customization.
Second concern is that, IMHO, we shouldn't allow 2 different syntax to
reference trafficserver issues in documentation.
This usually leads to confusion (why should I use one more than another ?)
Finally, the fix I made has another positive effect: we now have a
consistent way of referencing issues, for both Jira & Github. For now, I don't
see any way to differentiate Jira & github ones with the Autolink feature.
My 2 cents,
Issue Time Tracking
-------------------
Worklog Id: (was: 34988)
Time Spent: 2.5h (was: 2h 20m)
> ATS 7.0.0 doesn't build against python docutils 0.13.1
> ------------------------------------------------------
>
> Key: TS-5107
> URL: https://issues.apache.org/jira/browse/TS-5107
> Project: Traffic Server
> Issue Type: Bug
> Components: Documentation
> Reporter: Jean Baptiste Favre
> Assignee: Jean Baptiste Favre
> Fix For: 7.0.1
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Trying to build ATS 7.0.0 with python docutils 0.13.1 on Debian fails
> with following error:
> {code}Making all in doc
> make[2]: Entering directory '/home/debocker/source/build/doc'
> PAPEROPT_a4="-D latex_paper_size=a4" PAPEROPT_letter="-D
> latex_paper_size=letter" PAPER="letter" ./sbuild sphinx-build -c . -d
> docbuild/doctrees -b man . docbuild/man
> Running Sphinx v1.4.9
> making output directory...
> WARNING: sphinx.ext.pngmath has been deprecated. Please use
> sphinx.ext.imgmath instead.
> loading pickled environment... not yet created
> building [mo]: targets for 0 po files that are out of date
> building [man]: all manpages
> updating environment: 456 added, 0 changed, 0 removed
> reading sources... [ 0%] admin-guide/configuration/cache-basics.en
> Exception occurred:
> File "conf.py", line 185, in __init__
> start_string_prefix=self.start_string_prefix,
> AttributeError: Inliner instance has no attribute 'start_string_prefix'
> The full traceback has been saved in /tmp/sphinx-err-5iq_t9.log, if you
> want to report the issue to the developers.
> Please also report this if it was a user error, so that a better error
> message can be provided next time.
> A bug report can be filed in the tracker at
> <https://github.com/sphinx-doc/sphinx/issues>. Thanks!
> Makefile:998: recipe for target 'man' failed
> make[2]: Leaving directory '/home/debocker/source/build/doc'
> make[2]: *** [man] Error 1
> make[1]: *** [all-recursive] Error 1{code}
> I tracked it down to
> [docutils/parsers/rst/states.py|https://fossies.org/diffs/docutils/0.12_vs_0.13.1/docutils/parsers/rst/states.py-diff.html]
> which changed
> between 0.12 & 0.13.1
> {{start_string_prefix}} is not defined anymore at {{Inliner}} init. We have to
> call {{init_cutomizations}} method, but I can't figure out the {{settings}}
> structure.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
