GitHub user jablko opened a pull request:

    https://github.com/apache/trafficserver/pull/1362

    If setrlimit() fails, log the details

    I guess this is the same error as TS-882 [1] and TS-3074 [2]. The relevant 
commits are 8d7bb47419b25e50a5c50b53e54ce6dc5b342ef4 and 
10a361304cf8e121a8c6dfaf1fa0dd19089fef90.
    
    But I don't know why there's a problem with setrlimit() and RLIM_INFINITY 
on FreeBSD, OpenBSD, etc. So my thought is to replace the assert with a log 
message, as suggested by @SolidWallOfCode in TS-882. That'll fix the failing 
assertion immediately, and maybe provide enough details to fix the underlying 
failure?
    
    Can we drop the ``#if !(defined(darwin) || defined(freebsd))`` as well?
    
    @jirib what happens when you apply this patch?
    
    Fixes #1354
    
    [1] https://issues.apache.org/jira/browse/TS-882
    [2] https://issues.apache.org/jira/browse/TS-3074

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jablko/trafficserver setrlimit

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/1362.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1362
    
----
commit c5da11e09b785bad61aa93a93bc3b62d82f5beae
Author: Jack Bates <j...@nottheoilrig.com>
Date:   2017-01-23T23:01:37Z

    If setrlimit() fails, log the details
    
    Fixes #1354

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to