Github user jablko commented on the issue:

    https://github.com/apache/trafficserver/pull/1378
  
    > Also, please remember to add Milestone, Label's etc. on each Issue / PR, 
otherwise @bryancall gets all pissy. :)
    
    Will do! :-)
    
    > Why are there 4 commits on this? Can you squash those? Or do we actually 
need these reverts as well?
    
    Make that 5 ... I just added #1377 to this PR because this is broken 
without it. Whoops.
    
    I think we need the reverts, this doesn't apply without them, and I think 
it makes most sense to maintain the parallel between the commits we're 
backporting and master -- so apply them as individual commits. That said, I'm 
happy to do it differently! I'm happy to squash any combination of them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to