GitHub user ykopel opened a pull request:
https://github.com/apache/trafficserver/pull/1470
Fix for tr-pass handling
The commit of
https://github.com/apache/trafficserver/commit/497e4755d7773590204b89b6c262f6605a9c8e21
Caused to all the cases that will go into this "if" to be bypassed.
I commented there:
These lines will cause each request to fall to passthrough bypass:
```
// If we had a GET request that has data after the
// get request, do blind tunnel
} else if (state == PARSE_DONE &&
t_state.hdr_info.client_request.method_get_wksidx() ==
HTTP_WKSIDX_GET &&
ua_raw_buffer_reader->read_avail() > 0 &&
!t_state.hdr_info.client_request.is_keep_alive_set()) {
do_blind_tunnel = true;
}
```
This is because ua_raw_buffer_reader->read_avail() always will be grater
than zero.
You haven't see it until now because of another bug
(https://github.com/ykopel/trafficserver/commit/58177385afb0111bbcc9da08c43c6d76c76f372d)
that cause is_transparent_passthrough_allowed() to be always false and this
for it never reached to your lines.
This is why I suggest to just delete them meantime.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ykopel/trafficserver master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1470.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1470
----
commit ada7defa9493ee1b14fb8f5295fb52c30963b45a
Author: ykopel <[email protected]>
Date: 2017-02-16T13:18:22Z
Fix for "tr-pass handling
Fix for
https://github.com/apache/trafficserver/commit/497e4755d7773590204b89b6c262f6605a9c8e21
commit 4771273371839eb972f8d88a7f3569d4f0b4f60f
Author: ykopel <[email protected]>
Date: 2017-02-16T13:20:52Z
Merge pull request #1 from ykopel/ykopel-patch-fix-2
Fix for "tr-pass handling
commit 62b645c955f52d5cde46d71e46620fd797936c6f
Author: ykopel <[email protected]>
Date: 2017-02-16T13:24:29Z
Update HttpTransact.cc
commit b1eb0cd0e378cb06f7458027768c53af61d30c74
Author: ykopel <[email protected]>
Date: 2017-02-16T13:27:12Z
Merge pull request #2 from ykopel/ykopel-patch-1
Avoid forcing "proxied URL" in case of transparent request #1448
commit 1c2523651f08479d8d432fc75acee9fafbfbbee0
Author: ykopel <[email protected]>
Date: 2017-02-16T14:35:59Z
is_transparent_passthrough_allowed always returns false
commit 58177385afb0111bbcc9da08c43c6d76c76f372d
Author: ykopel <[email protected]>
Date: 2017-02-16T14:36:44Z
Merge pull request #3 from ykopel/ykopel-patch-1
is_transparent_passthrough_allowed always returns false
commit 93e725d915c7946945acd9cfa21519af8b94c52e
Author: ykopel <[email protected]>
Date: 2017-02-19T07:05:58Z
Revert "is_transparent_passthrough_allowed always returns false"
commit 7ceab16d5b492c10554b5d9681f910acc402b04c
Author: ykopel <[email protected]>
Date: 2017-02-19T07:06:15Z
Merge pull request #4 from ykopel/revert-3-ykopel-patch-1
Revert "is_transparent_passthrough_allowed always returns false"
commit 419ba9a078e1fc1570eeaf1cef662b86be141f5d
Author: ykopel <[email protected]>
Date: 2017-02-19T07:07:02Z
Revert "Avoid forcing "proxied URL" in case of transparent request #1448"
commit 9ccb452326ccf68b21f1fdc55609569f768546f5
Author: ykopel <[email protected]>
Date: 2017-02-19T07:07:08Z
Merge pull request #5 from ykopel/revert-2-ykopel-patch-1
Revert "Avoid forcing "proxied URL" in case of transparent request #1448"
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
