Github user zwoop commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/1494#discussion_r103118913
  
    --- Diff: configure.ac ---
    @@ -307,6 +307,19 @@ AC_ARG_WITH([profiler],
     )
     AC_MSG_RESULT([$with_profiler])
     
    +# System luajit
    +AC_MSG_CHECKING([whether to enable system luajit])
    +AC_ARG_ENABLE([system-luajit],
    --- End diff --
    
    This looks odd, shouldn't that be AC_ARG_WITH ? Alternatively, the help 
text ought to say --enable-system-luajit, right? I think in general, libraries 
are specified with --with- options, right? E.g.
    
    ```
    --with-system-luajit=/opt/luajit
    ```
    
    Wonder if "system" is redundant here in that case? But I realize this patch 
doesn't support this, for now, but it'd be nice not having to change the 
configure option if someone adds support for this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to