Github user danobi commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1516#discussion_r104771989
--- Diff: plugins/esi/combo_handler.cc ---
@@ -187,6 +207,94 @@ InterceptData::~InterceptData()
}
}
+void
+CacheControlHeader::update(TSMBuffer bufp, TSMLoc hdr_loc)
+{
+ vector<string> values;
--- End diff --
Why a loop? If we use a loop then it's harder to set the `found_private`
and `found_immutable` flags. I feel like unrolling the loop in this case is
better since the # of parameters in Cache-Control is known.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
