shinrich opened a new issue #7574:
URL: https://github.com/apache/trafficserver/issues/7574


   I accidentally ran across this while doing "traffic_ctl config match".  
There is no documentation.  Looking in the code I get the following from 
HttpTransact.cc in HttpTransact::initialize_state_variables_from_request
   
   ```
     // If this is an internal request, never keep alive
     if (!s->txn_conf->keep_alive_enabled_in) {
       s->client_info.keep_alive = HTTP_NO_KEEPALIVE;
     } else if (vc && vc->get_is_internal_request()) {
       // Following the trail of JIRAs back from TS-4960, there can be issues 
with
       // EOS event delivery when using keepalive on internal PluginVC session. 
As
       // an interim measure, if proxy.config.http.keepalive_internal_vc is set,
       // we will obey the incoming transaction's keepalive request.
       s->client_info.keep_alive =
         s->http_config_param->keepalive_internal_vc ? 
incoming_request->keep_alive_get() : HTTP_NO_KEEPALIVE;
     } else {
       s->client_info.keep_alive = incoming_request->keep_alive_get();
     }
   ```
   
   We run with this set to 0.
   
   Tracking down "git blame" for the relevant lines.  Since this was proposed 
as an interim solution, perhaps we can remove it?
   
   ```
   commit b31ae0bf97ed5e6943a2a1311ea70b67aa7964ef
   Author: James Peach <[email protected]>
   Date:   Wed Oct 12 15:28:27 2016 -0700
   
       TS-4963: Add option to obey keepalive on internal transactions.
       
       Add the proxy.config.http.keepalive_internal_vc configuration option
       to obey the keepalive state on internal transactions. This should be
       considered an interim measure until the problems around event delivery
       on half-closed internal sessions are investigated.
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to