Johanhen commented on issue #7656:
URL: https://github.com/apache/trafficserver/issues/7656#issuecomment-811154948
On 31/03/2021 17:11, Brian Geffon wrote:
>
> Sorry my bad the autoconf script always defines TS_USE_EPOLL, you need
> to do:
>
> The easiest fix is:
>
> |sed -Ei 's/#ifdef HAVE_EVENTFD/#if defined(HAVE_EVENTFD) \&\&
> TS_USE_EPOLL == 1' src/tscore/EventNotify.cc |
>
> That should fix it, but that whole class is kinda ridiculous anyway.
> Using eventfd + epoll in this way is overkill, the ink_condwait
> methods should be preferred for many reasons as they solve the same
> problem:
>
> 1. ink_condwait and friends will wrap into pthread_cond_(timed)wait
> which are as the name implies posix compliant.
> 2. When using pthread_cond_wait In the case of a signal before a wait
> no syscall is ever required on most platforms, ie. linux uses
> futex(2) on contention but it will check the state in userspace
> before making a syscall.
> 3. Using eventfd(2) in this way doesn't make sense as you're never
> acutally using the FD with anything other than this epoll fd.
> 4. Even if you choose to use eventfd(2) in this way it should
> probably use poll(2) as it's posix compliant, whereas epoll is
> linux specific.
>
> Eventfds make sense in situations where you have an existing pollfd /
> epollfd / etc where you want to tack on some event notification, when
> you're creating an eventfd to use only with poll/epoll/etc there
> usually is a better way.
>
> My suggestion is: just yank out all of this eventfd / epoll code and
> make it use ink_cond_wait/ink_cond_timedwait and be done with it.
>
I now get the following error.
libtool: compile: c++ -DHAVE_CONFIG_H -I. -I../../include
-D_GLIBCXX_USE_C99 -D_GLIBCXX_USE_C99_MATH -D_GLIBCXX_USE_C99_MATH_TR1
-Dfreebsd -D_LARGEFILE64_SOURCE=1 -D_COMPILE64BIT_SOURCE=1 -D_REENTRANT
-D__STDC_LIMIT_MACROS=1 -D__STDC_FORMAT_MACROS=1
-I/usr/ports/www/trafficserver/work/trafficserver-8.1.1/iocore/eventsystem
-I/usr/ports/www/trafficserver/work/trafficserver-8.1.1/iocore/net
-I/usr/ports/www/trafficserver/work/trafficserver-8.1.1/iocore/aio
-I/usr/ports/www/trafficserver/work/trafficserver-8.1.1/iocore/hostdb
-I/usr/ports/www/trafficserver/work/trafficserver-8.1.1/iocore/cache
-I/usr/ports/www/trafficserver/work/trafficserver-8.1.1/iocore/utils
-I/usr/ports/www/trafficserver/work/trafficserver-8.1.1/iocore/dns
-I/usr/ports/www/trafficserver/work/trafficserver-8.1.1/include
-I/usr/ports/www/trafficserver/work/trafficserver-8.1.1/include/records
-I/usr/ports/www/trafficserver/work/trafficserver-8.1.1/lib
-I/usr/local/include -I/usr/local/include/tcl8.6
-I/usr/ports/www/trafficserver/work/trafficserver-8.1.1/lib/yamlcpp/include
-isystem /usr/local/include -D_GNU_SOURCE -I/usr/include
-DOPENSSL_NO_SSL_INTERN -I/usr/local/include -std=c++17 -g -pipe -Wall
-Wno-deprecated-declarations -Qunused-arguments -Wextra
-Wno-ignored-qualifiers -Wno-unused-parameter -fno-strict-aliasing
-Wno-invalid-offsetof -mcx16 -O2 -pipe -fstack-protector-strong -isystem
/usr/local/include -fno-strict-aliasing -isystem /usr/local/include -c
EventNotify.cc -fPIC -DPIC -o .libs/EventNotify.o
EventNotify.cc:58:18: error: use of undeclared identifier 'm_cond'
ink_cond_init(&m_cond);
^
EventNotify.cc:59:19: error: use of undeclared identifier 'm_mutex'
ink_mutex_init(&m_mutex);
^
EventNotify.cc:75:20: error: use of undeclared identifier 'm_cond'
ink_cond_signal(&m_cond);
^
EventNotify.cc:102:18: error: use of undeclared identifier 'm_cond'
ink_cond_wait(&m_cond, &m_mutex);
^
EventNotify.cc:102:27: error: use of undeclared identifier 'm_mutex'
ink_cond_wait(&m_cond, &m_mutex);
^
EventNotify.cc:143:30: error: use of undeclared identifier 'm_cond'
return ink_cond_timedwait(&m_cond, &m_mutex, &abstime);
^
EventNotify.cc:143:39: error: use of undeclared identifier 'm_mutex'
return ink_cond_timedwait(&m_cond, &m_mutex, &abstime);
^
EventNotify.cc:153:22: error: use of undeclared identifier 'm_mutex'
ink_mutex_acquire(&m_mutex);
^
EventNotify.cc:163:33: error: use of undeclared identifier 'm_mutex'
return ink_mutex_try_acquire(&m_mutex);
^
EventNotify.cc:173:22: error: use of undeclared identifier 'm_mutex'
ink_mutex_release(&m_mutex);
^
EventNotify.cc:183:21: error: use of undeclared identifier 'm_cond'
ink_cond_destroy(&m_cond);
^
EventNotify.cc:184:22: error: use of undeclared identifier 'm_mutex'
ink_mutex_destroy(&m_mutex);
^
In file included from EventNotify.cc:30:
../../include/tscore/EventNotify.h:49:7: warning: private field
'm_event_fd' is not used [-Wunused-private-field]
int m_event_fd;
^
../../include/tscore/EventNotify.h:50:7: warning: private field
'm_epoll_fd' is not used [-Wunused-private-field]
int m_epoll_fd;
^
2 warnings and 12 errors generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
