shinrich commented on issue #7471: URL: https://github.com/apache/trafficserver/issues/7471#issuecomment-833108526
The clearing of the server_session in HttpSM::kill_this is concerning. As discussed in the "Cleaning up" session of my notes on the H2 to origin PR notes, there are multiple references to the server_session in the tunnel, server_entry, and in the server_session member variable. With the H2 to origin keeping track of all of that was made even worse by the possibility of two origin classes. Any kind of characterization of the leaking transaction scenario would be useful. It is quite likely that we are leaking too, but given our transaction distribution not at such a high rate. https://docs.google.com/document/d/1sK6AyR-1K795NHsJqpRp4pjZRJ7T5KM78uJlRFMpKiI/edit?usp=sharing I'll think some more if we can backport a more systematic means of ensuring the server_session has been freed by the time we get to HttpSM::kill_this. Just calling do_io_close against the server_session object in HttpSM::kill_this is unlikely to work since there are many cases where the HttpServerSession object has already been freed (via the tunnel or the server_entry). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
