bneradt commented on issue #3551: URL: https://github.com/apache/trafficserver/issues/3551#issuecomment-866085901
I did an experiment with the new CI job to verify it functions like we expect it to. A week ago I made the following PR to fix the catch tests when compiled against openssl-quic: https://github.com/apache/trafficserver/pull/7944 I did the following run against master, which has the fix from that PR: https://jenkins.trafficserver.org/view/Github/job/Github_Builds/job/centos/37/ The test passed, as expected. I then did the following run on the commit before that PR got merged in: https://jenkins.trafficserver.org/view/Github/job/Github_Builds/job/centos/38/ That job failed, as expected since there was a compilation issue with the openssl QUIC unit tests: ``` In file included from ./test/test_QUICFlowController.cc:27: ../quic/Mock.h:198:3: error: 'int MockQUICConnectionInfoProvider::select_next_protocol(SSL*, const unsigned char**, unsigned char*, const unsigned char*, unsigned int) const' marked 'override', but does not override select_next_protocol(SSL *ssl, const unsigned char **out, unsigned char *outlen, const unsigned char *in, ^~~~~~~~~~~~~~~~~~~~ ../quic/Mock.h:516:3: error: 'int MockQUICConnection::select_next_protocol(SSL*, const unsigned char**, unsigned char*, const unsigned char*, unsigned int) const' marked 'override', but does not override select_next_protocol(SSL *ssl, const unsigned char **out, unsigned char *outlen, const unsigned char *in, ^~~~~~~~~~~~~~~~~~~~ ``` This demonstrates that the new CI job is compiling the unit and regression tests against openssl-quic as we desire and is capable of finding issues with openssl-quic builds. Again, as mentioned in the previous comment, I'll leave this issue open until we transition to the new CI system and new PRs are run against this job. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
