maskit commented on issue #11377: URL: https://github.com/apache/trafficserver/issues/11377#issuecomment-2123020662
> I just believe that warning suppression is bad because the warnings sometimes point to real issues/bugs and we should use any help from the compiler and the other tools to catch bugs as early as possible (preferably at compile time, instead at runtime). I completely agree. And I feel like many of the inline suppressions in the ATS codebase are unnecessary (could be avoided), although some places may really need it. If the suppression is necessary, I'd go with the standard way, `maybe_unused` attribute, because it potentially helps code analyzers and other tools. But it's just my opinion. It'd be great if you could make Pull-Requests for this. There may be places that are debatable, and you may see some pushbacks but having Pull-Requests would be still nice. The only place I don't want you to touch for this is `lib/`, because it has third-party libraries. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@trafficserver.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
