brbzull0 commented on issue #11649: URL: https://github.com/apache/trafficserver/issues/11649#issuecomment-2271163942
Adding some notes here [proxy.config.http2.default_buffer_water_mark](http://fedora/admin-guide/files/records.yaml.en.html#proxy-config-http2-default-buffer-water-mark) ``` When set to -1 (default), a thread will accept connections as long as there are connections waiting in its listening queue.is equivalent to “accept all”, and setting to 0 is equivalent to “accept one”. ``` It seems we expect to be a signed integer, but [here](https://github.com/apache/trafficserver/blob/master/src/proxy/http2/HTTP2.cc#L505) says the contrary, so when we [read](https://github.com/apache/trafficserver/blob/e579cabec848a9b46a32ca6d402952899f04b7fc/src/proxy/http2/HTTP2.cc#L563) the value, it could end up with some unwanted value in it, the assignment of this value goes from unsigned to signed. If we expect this to hold -1 then we need to make all the types consistent I guess TBC [proxy.config.net.additional_accepts](http://fedora/admin-guide/files/records.yaml.en.html#proxy-config-net-additional-accepts) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
