bneradt commented on issue #12140:
URL: 
https://github.com/apache/trafficserver/issues/12140#issuecomment-2852469953

   It's interesting that the crash happens in this OpenSSL call here:
   
https://github.com/apache/trafficserver/blob/2fc1735c0592030fd5d2825bf57affd16603cd89/src/iocore/net/SSLUtils.cc#L1092
   
   I'm not sure why calling `SSL_get_negotiated_group` with what should 
otherwise be a valid `SSL*` object (it was used multiple times earlier in the 
function) should cause an issue.
   
   I verified that if I simplified the #11844 to this single line addition, I 
still get this crash:
   
   ```patch
   diff --git a/src/iocore/net/SSLUtils.cc b/src/iocore/net/SSLUtils.cc
   index a71180fa2..47992de89 100644
   --- a/src/iocore/net/SSLUtils.cc
   +++ b/src/iocore/net/SSLUtils.cc
   @@ -1077,6 +1077,8 @@ ssl_callback_info(const SSL *ssl, int where, int ret)
          }
          Metrics::Counter::increment(it->second);
        }
   +
   +    SSL_get_negotiated_group(const_cast<SSL *>(ssl));
      }
    }
    ```
   
   Therefore simply calling `SSL_get_negotiated_group(const_cast<SSL *>(ssl));` 
in `ssl_callback_info` causes this crash.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to