djcarlin commented on issue #12324: URL: https://github.com/apache/trafficserver/issues/12324#issuecomment-4513278592
I saw an issue today editing plugin.config (e.g. adding a new global header_rewrite.so /path/to/conf line) followed by traffic_ctl config reload: - traffic_ctl returns success - traffic_ctl config status shows Reconfigured at: `<timestamp>`, Reconfigure required: no, Restart required: no - diags.log / traffic.out: nothing - The plugin is silently not loaded — only verifiable by behavioral test (e.g. curl shows the header_rewrite rule didn't run) I had Cursor/Claude trace through the code: FileManager detects the mtime change (AddConfigFilesHere.cc registers plugin.config), but the only registered callback (process_config_update in FileManager.cc) no-ops for files with empty configName, which plugin.config has. plugin_init() is only called once at startup (traffic_server.cc:2232). PR #12892's design table lists plugin.config as (static, no handler), so the new framework preserves this behavior. I understand reloading global plugins is out of scope (per the [Reloading Plugins design doc](https://docs.trafficserver.apache.org/developer-guide/design-documents/reloading-plugins.en.html): "Currently only loading of 'remap' plugins (remap.config) is supported"). But could the new framework at least flip Restart required: yes (or emit a Warning) when plugin.config mtime changes during a reload? Right now operators have no signal at all that their edit didn't take effect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
