mmustafasenoglu commented on issue #5742: URL: https://github.com/apache/trafficserver/issues/5742#issuecomment-4826892246
Hi @JosiahWI, @jpeach Thanks for the question. To be transparent, I haven't personally verified the exact hook behavior in the Traffic Server source code. The documentation change was based on the original issue reporter's experience (#5742) who stated that `TSUrlHostGet` only works after `TS_HTTP_POST_REMAP_HOOK`. However, @jpeach's point is valid — `TSUrlHostGet` operates on a marshal buffer URL, so in theory it should work on any properly parsed URL regardless of hook phase. I think the safest path forward is: 1. If the original issue reporter's use case was actually about the URL not being fully populated in earlier hooks (rather than the function itself failing), the note may be misleading 2. If there's a real difference in behavior between hook phases, we should document the specific reason why I'm happy to update or close the PR based on the maintainers' consensus. If the function truly works at any point after URL parsing, we should probably close #5742 as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
