bryancall commented on issue #8426: URL: https://github.com/apache/trafficserver/issues/8426#issuecomment-4827449459
In current master SO_LINGER is opt-in and off by default. The abortive close (SO_LINGER with a linger value of 0) is applied only when the SOCK_OPT_LINGER_ON flag (bit 0x4) is set in proxy.config.net.sock_option_flag_in or sock_option_flag_out (see src/iocore/net/UnixConnection.cc and src/iocore/net/Server.cc, and the flag definition in include/iocore/net/NetVCOptions.h). Both of those settings default to 0x1, which enables TCP_NODELAY only, so linger is not enabled by the default configuration. The concern raised here (that propagating proxy.config.net.sock_option_flag_in to client connections would turn linger on by default) does not apply, since the default flag value does not include the linger bit, and the discussion converged on keeping the abortive close as an opt-in mitigation rather than removing it. Since the behavior now matches that outcome, I am closing this. Please reopen if you want the linger option removed entirely rather than left opt-in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
