bryancall commented on issue #10504:
URL: 
https://github.com/apache/trafficserver/issues/10504#issuecomment-4828154238

   This crash was fixed by [PR 
#11410](https://github.com/apache/trafficserver/pull/11410), first released in 
10.0.0. The backtrace shows `restart_receiving()` being called on a session 
that was already closing, where the underlying network virtual connection had 
been torn down, so `session->get_netvc()` returned null and the subsequent 
`get_service<TLSSNISupport>()` dereferenced a null pointer. The fix adds an 
early return in `Http2ConnectionState::restart_receiving()` when the peer 
connection is already closed (and a matching guard in 
`Http2CommonSession::_should_do_something_else()`), so the 
configured-window-size lookup is never reached on a closed connection. I 
confirmed the guard is present on master and that backing out the change you 
originally pointed at is no longer needed. Closing as fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to