bryancall commented on issue #11907: URL: https://github.com/apache/trafficserver/issues/11907#issuecomment-4828270573
This was a real defect, and it is now fixed. Before the fix, none of the three origin connect-attempt retry settings were applied correctly: an unresponsive origin kept receiving the full `connect_attempts_max_retries` attempts on every request, the host never transitioned to the down state, and `connect_attempts_max_retries_down_server` (even set to 0) never took effect, so the "Not connecting to the server because it is marked down" trace never appeared. [PR #13102](https://github.com/apache/trafficserver/pull/13102) ("Fix connect attempt retries") reworks the retry path so it honors the HostDB state of the origin: a recovering (suspect) origin gets the limited probe budget, and an origin that is fully down gets zero connect attempts. It also fixes the failure-count threshold used to mark a host down and timestamps each connect attempt distinctly so a host actually reaches the down state, and it adds tests for the down/recovering behavior. As part of the change the setting was renamed from `proxy.config.http.connect_attempts_max_retries_down_server` to `proxy.config.http.connect_attempts_max_retries_suspect_server` to match the recovering (suspect) state it actually governs, with the old name kept working via a deprecation warning. This change is on master and first ships in the 10.2.0 release. Closing as fixed. Please reopen if you still see a fully unresponsive origin getting more than the configured attempts on 10.2.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
