moonchen opened a new issue, #13364:
URL: https://github.com/apache/trafficserver/issues/13364

   `proxy.config.proxy_protocol.max_header_size` is declared `RECU_DYNAMIC`, 
but changing it and running `traffic_ctl config reload` does not apply the new 
value until an unrelated SSL cert/key/keylog/multicert reload — or a restart.
   
   It is read only in `SSLConfigParams::initialize()` (via `RecGetRecordInt`), 
which re-runs only from `SSLConfig::reconfigure()`. The only trigger that fires 
`SSLClientCoordinator::reconfigure()` → `SSLConfig::reconfigure()` is the 
cert/key/keylog/multicert record list registered in `SSLClientCoordinator.cc`, 
which does not include `proxy.config.proxy_protocol.max_header_size`. So a 
standalone change to this record is silently ignored on reload, contradicting 
its `RECU_DYNAMIC` (reloadable) declaration.
   
   Refs (master): record declared `RECU_DYNAMIC` in 
`src/records/RecordsConfig.cc`; read in `SSLConfigParams::initialize()` and 
re-read from `SSLConfig::reconfigure()` (`src/iocore/net/SSLConfig.cc`); 
trigger-record list in `src/iocore/net/SSLClientCoordinator.cc`.
   
   Fix: add the record to that trigger list so `initialize()` re-runs on its 
change, or mark it `RECU_RESTART_TS` to match actual behavior.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to