[ https://issues.apache.org/jira/browse/TRAFODION-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16489296#comment-16489296 ]
ASF GitHub Bot commented on TRAFODION-3070: ------------------------------------------- Github user DaveBirdsall commented on a diff in the pull request: https://github.com/apache/trafodion/pull/1578#discussion_r190645661 --- Diff: core/sql/sqlcomp/CmpSeabaseDDLcommentOn.cpp --- @@ -229,6 +229,16 @@ void CmpSeabaseDDL::doSeabaseCommentOn(StmtDDLCommentOn *commentOnNode, enum ComObjectType enMDObjType = COM_UNKNOWN_OBJECT; ComObjectName objectName(commentOnNode->getObjectName()); + //we can not comment on native hive table. + if (str_cmp(toUpper(currCatName.data()), "HIVE", 4) == 0) --- End diff -- Please use the literal HIVE_SYSTEM_CATALOG (see common/ComSmallDefs.h) instead of hard-coding "HIVE". > Cannot create comment on HIVE table > ----------------------------------- > > Key: TRAFODION-3070 > URL: https://issues.apache.org/jira/browse/TRAFODION-3070 > Project: Apache Trafodion > Issue Type: Bug > Components: sql-general > Affects Versions: any > Reporter: zhang.lei > Assignee: zhang.lei > Priority: Major > Fix For: any > > > I cannot create comment on HIVE table. > SQL>comment on table hive.hive.test01 is 'test'; > ---ERROR[1389] Object HIVE.HIVE.TEST01 does not exist in Trafodion. > [2018-05-14 15:51:31] > Then I create an external table in trafci for the hive table. > SQL>create external table test01(a largeint,b varchar(4), c varchar(4)) for > hive.hive.test01; > — SQL operation complete. > And I found I can create comment on the external table. > SQL>comment on table "__HV_HIVE__".test01 is 'test'; > — SQL operation complete. > SQL>showddl "__HV_HIVE__".test01; > CREATE EXTERNAL TABLE TEST01 > ( > A LARGEINT DEFAULT NULL NOT SERIALIZED > , B VARCHAR(4) CHARACTER SET ISO88591 COLLATE > DEFAULT DEFAULT NULL NOT SERIALIZED > , C VARCHAR(4) CHARACTER SET ISO88591 COLLATE > DEFAULT DEFAULT NULL NOT SERIALIZED > ) > FOR HIVE.HIVE.TEST01 > ; > COMMENT ON TABLE TRAFODION."__HV_HIVE__".TEST01 IS 'test' ; > After that, I try to create comment on the HIVE table. > The comment statement completes and I check ddls of the HIVE table. > But the comment 'test0102' doesn't appear in the ddl. > And comment statement are in front of the semicolon that is the end sign for > external table ddl. > SQL>comment on table hive.hive.test01 is 'test0102'; > — SQL operation complete. > SQL>showddl hive.hive.test01; > /* Hive DDL */ > CREATE TABLE DEFAULT.TEST01 > ( > A bigint > , B char(4) > , C char(4) > ) > stored as textfile > ; > /* Trafodion DDL */ > REGISTER /*INTERNAL*/ HIVE TABLE HIVE.HIVE.TEST01; > /* ObjectUID = 1137319817757950657 */ > CREATE EXTERNAL TABLE TEST01 > ( > A LARGEINT DEFAULT NULL NOT SERIALIZED > , B VARCHAR(4) CHARACTER SET ISO88591 COLLATE > DEFAULT DEFAULT NULL NOT SERIALIZED > , C VARCHAR(4) CHARACTER SET ISO88591 COLLATE > DEFAULT DEFAULT NULL NOT SERIALIZED > ) > FOR HIVE.HIVE.TEST01 > COMMENT ON TABLE TRAFODION."__HV_HIVE__".TEST01 IS 'test' ; > ; -- This message was sent by Atlassian JIRA (v7.6.3#76005)