[ 
https://issues.apache.org/jira/browse/TRAFODION-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16588918#comment-16588918
 ] 

Selvaganesan Govindarajan commented on TRAFODION-3187:
------------------------------------------------------

It will be good to add a test case or the symptom of the problem that enabled 
you to arrive at the conclusion in the JIRA.  The symptom will enable the users 
to pick up this patch if they happen to hit the same issue. Otherwise, users 
wouldn't know when to pick up this patch

> ref count of ComDiagsArea is not increased 
> -------------------------------------------
>
>                 Key: TRAFODION-3187
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-3187
>             Project: Apache Trafodion
>          Issue Type: Bug
>          Components: -exe
>    Affects Versions: 2.4
>            Reporter: Wenjun Zhu
>            Assignee: Wenjun Zhu
>            Priority: Minor
>             Fix For: 2.4
>
>
> code of ExTupleFlowTcb::work() in core/sql/executor/ex_tuple_flow.cpp
> {code:java}
> 308 if ((pstate.tgtRowsSent_ == FALSE) &&
> 309 (src_entry->getDiagsArea()))
> 310 {
> 311 // a warning is returned with EOD and
> 312 // nothing else was returned from source.
> 313 // Move warning to parent's up queue.
> 314 if (qParent_.up->isFull())
> 315 return WORK_OK;
> 316
> 317 ex_queue_entry * up_entry =
> 318 qParent_.up->getTailEntry();
> 319 up_entry->setDiagsArea(src_entry->getDiagsArea());
> 320 }
> {code}
> has not increased the ref count, compared to the following correct one:
>  
> {code:java}
> 294   if (from->getDiagsArea())
> 295     from->getDiagsArea()->incrRefCount();
> 296
> 297   setDiagsArea(from->getDiagsArea());
> {code}
> of atp_struct::copyAtp() in ore/sql/exp/ExpAtp.h
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to