[
https://issues.apache.org/jira/browse/TRAFODION-1521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14955165#comment-14955165
]
ASF GitHub Bot commented on TRAFODION-1521:
-------------------------------------------
Github user robertamarton commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/118#discussion_r41885829
--- Diff: core/sqf/sqenvcom.sh ---
@@ -580,6 +547,13 @@ EOF
echo "**** ERROR: Unable to determine location of HBase lib directory"
fi
+ if [[ -d $TOOLSDIR/thrift-0.9.0 ]]; then
+ # this is mostly for a build environment, where we need
+ # thrift from TOOLSDIR
+ export THRIFT_LIB_DIR=$TOOLSDIR/thrift-0.9.0/lib
+ export THRIFT_INC_DIR=$TOOLSDIR/thrift-0.9.0/include
+ fi
+
if [ -n "$HBASE_CNF_DIR" -a -n "$HADOOP_CNF_DIR" -a \
--- End diff --
You removed Thrift from the required list in bldenvchk and set the variable
only if Thrift is installed in the TOOLSDIR. What happens if Thrift is not
installed?
> Trafodion build should not require HBase to be installed
> --------------------------------------------------------
>
> Key: TRAFODION-1521
> URL: https://issues.apache.org/jira/browse/TRAFODION-1521
> Project: Apache Trafodion
> Issue Type: Bug
> Components: sql-general
> Affects Versions: 1.1 (pre-incubation)
> Environment: Any
> Reporter: Hans Zeller
> Assignee: Hans Zeller
> Labels: build
> Fix For: 1.2-incubating
>
> Original Estimate: 96h
> Remaining Estimate: 96h
>
> When we build Trafodion in a source tree, it should not be necessary to
> install HBase first.
> Until now, several build steps relied on an HBase installation:
> 1. Files in core/sql/executor include the libhdfs header file, hdfs.h. This
> file isn't available in the Trafodion source tree.
> 2. When we link certain executables like mxosrvr and sqlci, we specify
> -lhdfs, requiring the libhdfs.so DLL as well as the DLLs it depends on,
> libhadoop.so and libjvm.so.
> 3. Until recently, executor Java (core/sql/executor) files were compiled with
> javac invocations from a Makefile, requiring the HBase client jar files in
> the CLASSPATH. This got changed with TRAFODION-1502.
> 4. I missed some more Java files in the fix for TRAFODION-1502:
> core/sqf/src/seatrans/tm/hbasetmlib2. Those should also be moved to Maven.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
