[ 
https://issues.apache.org/jira/browse/TRAFODION-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15047743#comment-15047743
 ] 

ASF GitHub Bot commented on TRAFODION-1643:
-------------------------------------------

Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/197#discussion_r47035342
  
    --- Diff: 
core/sqf/src/seatrans/hbase-trx/src/main/java/org/apache/hadoop/hbase/regionserver/transactional/TrxTransactionState.java
 ---
    @@ -126,15 +130,49 @@
            }
            catch (NoSuchMethodException exc_nsm2) {
                sb_sqm_98_4 = false;
    +                LOG.info("Got info of Class ScanQueryMatcher for HBase 
version" + VersionInfo.getVersion());
            }
        }
    -
        if (sb_sqm_98_1) {
            LOG.info("Got info of Class ScanQueryMatcher for HBase 98.1");
        }
        if (sb_sqm_98_4) {
            LOG.info("Got info of Class ScanQueryMatcher for HBase 98.4");
        }
    +   
    +   
    +   Class scaninfoClazz = null;
    --- End diff --
    
    I believe scaninfoclazz should also be made static. Can you please check if 
the scanInfoConstructor becomes invalid if scanInfoclazz gets gc-ed. 


> instantiation of ScanInfo changed after hbase-0.98.8
> ----------------------------------------------------
>
>                 Key: TRAFODION-1643
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-1643
>             Project: Apache Trafodion
>          Issue Type: Bug
>            Reporter: mashengchen
>            Assignee: mashengchen
>
> after hbase-0.98.8(include 0.98.8), the instantiation process of 
> ScanInfo(class) is different from before, which need KeepDeletedCells(enum) 
> as parameter instead of boolean.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to