[
https://issues.apache.org/jira/browse/TRAFODION-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15183719#comment-15183719
]
ASF GitHub Bot commented on TRAFODION-1863:
-------------------------------------------
Github user zellerh commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/364#discussion_r55272540
--- Diff: core/sql/optimizer/ValueDesc.cpp ---
@@ -529,14 +529,13 @@ NABoolean ValueId::isAddedColumnWithNonNullDefault()
const{
default:
break;
}
- if (nac && nac->isAddedColumn() && nac->getDefaultValue())
+ if (nac && nac->getDefaultValue() &&
strcmp(nac->getDefaultValue(),"NULL") != 0)
--- End diff --
Agree with Selva that checking the enum is safer and more maintainable.
Maybe you can make this change in a future check-in, so you don't have to rerun
the regressions just for that?
> With hbase_filter_preds set to '2', wrong results are returned for a specific
> use case.
> ---------------------------------------------------------------------------------------
>
> Key: TRAFODION-1863
> URL: https://issues.apache.org/jira/browse/TRAFODION-1863
> Project: Apache Trafodion
> Issue Type: Bug
> Reporter: Selvaganesan Govindarajan
> Assignee: Eric Owhadi
>
> create table t056t57 (a1 numeric(2,2) signed default 0 not null);
> showddl t056t57;
> insert into t056t57 default values;
> select * from t056t57;
> >>select * from t056t57 ;
> A1
> -------
> .00
> --- 1 row(s) selected.
> >>cqd hbase_filter_preds '2' ;
> --- SQL operation complete.
> >>select * from t056t57 ;
> ..
> --- 0 row(s) selected.
> >>
> This was causing core/TEST056 to fail with PR #340.. Possibly similar issue
> is with core/TEST029 too, Currently this test case runs with
> hbase_filter_preds set to 'ON'
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
