[ https://issues.apache.org/jira/browse/TRAFODION-2046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15328689#comment-15328689 ]
ASF GitHub Bot commented on TRAFODION-2046: ------------------------------------------- Github user traflm commented on a diff in the pull request: https://github.com/apache/incubator-trafodion/pull/542#discussion_r66891200 --- Diff: core/sqf/src/seatrans/hbase-trx/src/main/java/org/apache/hadoop/hbase/coprocessor/transactional/TrxRegionEndpoint.java.tmpl --- @@ -359,7 +359,7 @@ CoprocessorService, Coprocessor { private static final int DEFAULT_SLEEP = 60 * 1000; private static final int DEFAULT_MEMORY_THRESHOLD = 100; // 100% memory used --- End diff -- In checkMemoryUsage(), it will check the current memory usage with this DEFAULT_MEMORY_THRESHOLD, if I change the DEFAULT_MEMORY_THRESHOLD, that logic will break. Here the change only change the startup value. The name of DEFAULT_MEMORY_THRESHOLD is confusing, it is not only setting a default value, but also setting a low watermark , so I cannot simply change that value. > change DTM's memoryUsageChore default settings to enable memory threthold > ------------------------------------------------------------------------- > > Key: TRAFODION-2046 > URL: https://issues.apache.org/jira/browse/TRAFODION-2046 > Project: Apache Trafodion > Issue Type: Improvement > Reporter: liu ming > Assignee: liu ming > > DTM provide MemoryUsageChore to monitor the memory pressure in a > RegionServer, when memory is beyond a defined threshold, it will give a > warning or prevent new operations based on a flag. > By default, the threshold is now 100%, and the flag is just warning. So that > means DTM coprocessor can use all RS memory and when it find memory pressure > , just print warning, instead of control new transaction. > This will lead to un-predictable behavior for certain fat transaction. > It is better to change the default setting to enable protection. -- This message was sent by Atlassian JIRA (v6.3.4#6332)