[
https://issues.apache.org/jira/browse/TRAFODION-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15702677#comment-15702677
]
ASF GitHub Bot commented on TRAFODION-2231:
-------------------------------------------
Github user prashanth-vasudev commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/725#discussion_r89842560
--- Diff: core/sqf/src/tm/tmddlrequests.cpp ---
@@ -34,57 +34,68 @@ using namespace std;
* Signature: ([B)V
*/
-JNIEXPORT jint JNICALL
Java_org_apache_hadoop_hbase_client_transactional_RMInterface_createTableReq
- (JNIEnv *pp_env, jobject pv_object, jbyteArray pv_tableDescriptor,
jobjectArray pv_keys, jint pv_numSplits, jint pv_keyLength, jlong pv_transid,
jbyteArray pv_tblname){
+JNIEXPORT jstring JNICALL
Java_org_apache_hadoop_hbase_client_transactional_RMInterface_createTableReq
+ (JNIEnv *pp_env, jobject pv_object, jbyteArray pv_tableDescriptor,
jobjectArray pv_keys, jint pv_numSplits, jint pv_keyLength, jlong pv_transid,
jbyteArray pv_tblname)
+{
- char la_tbldesc[TM_MAX_DDLREQUEST_STRING];
- char la_tblname[TM_MAX_DDLREQUEST_STRING];
- char* str_key;
- str_key = new char[pv_keyLength];
+ char *la_err_str = 0;
+ int la_err_len = 0;
char** la_keys;
- la_keys = new char *[TM_MAX_DDLREQUEST_STRING];
int lv_error = FEOK;
- int lv_tblname_len = pp_env->GetArrayLength(pv_tblname);
- if(lv_tblname_len > TM_MAX_DDLREQUEST_STRING) {
- cout << "Table name length is larger than max allowed" << endl;
+ int lv_tbldesc_length = pp_env->GetArrayLength(pv_tableDescriptor);
+ if(lv_tbldesc_length > TM_MAX_DDLREQUEST_STRING)
+ {
+ jstring lv_err_str = pp_env->NewStringUTF("Table Desc length is
larger than max allowed");
--- End diff --
la_keys gets allocated only at line 60. I guess we might be seeing
different version of the file from multiple commits in this PR, or I might be
overlooking something.
> DDL create/drop detailed error string is not propagated
> -------------------------------------------------------
>
> Key: TRAFODION-2231
> URL: https://issues.apache.org/jira/browse/TRAFODION-2231
> Project: Apache Trafodion
> Issue Type: Bug
> Components: dtm
> Reporter: Prashanth Vasudev
> Assignee: Prashanth Vasudev
> Fix For: 2.1-incubating
>
>
> TRAFODION-2148 takes care of reporting error code in failure scenario,
> however the cause/error string or stack trace is missing for additional info.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
