[
https://issues.apache.org/jira/browse/TRAFODION-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826441#comment-15826441
]
ASF GitHub Bot commented on TRAFODION-2351:
-------------------------------------------
Github user sureshsubbiah commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/914#discussion_r96464728
--- Diff: core/sql/exp/ExpHbaseInterface.cpp ---
@@ -271,7 +271,12 @@ Lng32 ExpHbaseInterface::coProcAggr(
char * getHbaseErrStr(Lng32 errEnum)
{
- return (char*)hbaseErrorEnumStr[errEnum - (Lng32)HBASE_MIN_ERROR_NUM];
+ Lng32 lv_errEnum;
+ if (errEnum < HBASE_MIN_ERROR_NUM || errEnum >= HBASE_MAX_ERROR_NUM)
+ lv_errEnum = HBASE_GENERIC_ERROR;
--- End diff --
It is good that we are adding this to catch unanticipated errors. Did
testing reveal any errors that are not on the list above. If yes, do you think
we can add to the list of errors in ExpHbaseDefs.h.
> Bulk load with log error rows enhancements
> ------------------------------------------
>
> Key: TRAFODION-2351
> URL: https://issues.apache.org/jira/browse/TRAFODION-2351
> Project: Apache Trafodion
> Issue Type: Bug
> Components: sql-exe
> Reporter: Selvaganesan Govindarajan
> Assignee: Selvaganesan Govindarajan
>
> Bulk load needs the following enhancements
> 1) Load with log error rows misses out some error rows being logged
> 2) Load with log error rows need to report if there are any error rows
> 3) Load with log error rows need to report where the error rows are logged
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
