[ 
https://issues.apache.org/jira/browse/TRAFODION-2682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16083239#comment-16083239
 ] 

ASF GitHub Bot commented on TRAFODION-2682:
-------------------------------------------

GitHub user zellerh opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/1174

    [TRAFODION-2682] JVM startup options like heap are not passed correctly

    Character arrays used to build the options went out of scope before
    they were passed to the JNI layer to create the JVM.
    
    Selva also requested that we use the default heap size defined in
    our code instead of the JVM default method of 1/4 the physical
    memory when a value <= 0 is passed in env var JVM_MAX_HEA_SIZE_MB.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zellerh/incubator-trafodion bug/2.2a

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/1174.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1174
    
----
commit ca8146ecce9724b6cd3ff935e12c6cbbcade8df8
Author: Hans Zeller <hzel...@apache.org>
Date:   2017-07-12T00:09:21Z

    [TRAFODION-2682] JVM startup options like heap are not passed correctly
    
    Character arrays used to build the options went out of scope before
    they were passed to the JNI layer to create the JVM.
    
    Selva also requested that we use the default heap size defined in
    our code instead of the JVM default method of 1/4 the physical
    memory when a value <= 0 is passed in env var JVM_MAX_HEA_SIZE_MB.

----


> JVM startup options like heap are not passed correctly
> ------------------------------------------------------
>
>                 Key: TRAFODION-2682
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-2682
>             Project: Apache Trafodion
>          Issue Type: Bug
>          Components: sql-exe
>    Affects Versions: 2.2-incubating
>            Reporter: Hans Zeller
>            Assignee: Hans Zeller
>             Fix For: 2.2-incubating
>
>
> Selva just found out that we don't pass the -Xmx option to the JVM when 
> creating it in the executor. This is due to a bug in the change I made for 
> TRAFODION-2637. I put character array variables into a local scope where I 
> shouldn't have done that.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to