[ 
https://issues.apache.org/jira/browse/TRAFODION-2683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16086826#comment-16086826
 ] 

ASF GitHub Bot commented on TRAFODION-2683:
-------------------------------------------

GitHub user anoopsharma00 opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/1179

    Few fixes, details listed below.

    -- fix an issue where multiple values inserted from a list would return
      error but each value inserted on its own would succeed.
      ex: create table ts (a timestamp);
          insert into ts values ('2017-01-01 10:10:10'), ('2018-01-01 
10:10:10');
    
    -- sometimes errors returned from child during hive inserts were not
       being returned. That has been fixed.
    
    -- TRAFODION-2683 extension.
       added a 'p' (prune) option which would cleanse and filter unneeded
       explain output. This helps in reducing output especially
       for larger explains.
    Ex:
    >>explain option 'p' select * from dual;
    
    ------------------------------------------------------ PLAN SUMMARY
    STATEMENT_NAME ........... NOT NAMED
    STATEMENT ................ select * from dual;
    
    ------------------------------------------------------- NODE LISTING
    ROOT ======================================  SEQ_NO 2    ONLY CHILD 1
    DESCRIPTION
      fragment_id ............ 0
      parent_frag ............ (none)
      fragment_type .......... master
      xn_access_mode ......... read_only
      auto_query_retry ....... enabled
      embedded_arkcmp ........ used
      select_list ............ %(0)
      input_variables ........ %(0), %(0), %(0)
    
    VALUES ====================================  SEQ_NO 1    NO CHILDREN
    DESCRIPTION
      fragment_id ............ 0
      parent_frag ............ (none)
      fragment_type .......... master
      tuple_expr ............. %(0)
    
    --- SQL operation complete.
    >>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anoopsharma00/incubator-trafodion 
ansharma_explain_br

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/1179.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1179
    
----
commit 5a244d532425a6a4aff19a5cd2cd6ab637ea9b0a
Author: Anoop Sharma <anoop.sha...@esgyn.com>
Date:   2017-07-14T04:18:03Z

    Few fixes, details listed below.
    
    -- fix an issue where multiple values inserted from a list would return
      error but each value inserted on its own would succeed.
      ex: create table ts (a timestamp);
          insert into ts values ('2017-01-01 10:10:10'), ('2018-01-01 
10:10:10');
    
    -- sometimes errors returned from child during hive inserts were not
       being returned. That has been fixed.
    
    -- TRAFODION-2683 extension.
       added a 'p' (prune) option which would cleanse and filter unneeded
       explain output. This helps in reducing output especially
       for larger explains.
    Ex:
    >>explain option 'p' select * from dual;
    
    ------------------------------------------------------ PLAN SUMMARY
    STATEMENT_NAME ........... NOT NAMED
    STATEMENT ................ select * from dual;
    
    ------------------------------------------------------- NODE LISTING
    ROOT ======================================  SEQ_NO 2    ONLY CHILD 1
    DESCRIPTION
      fragment_id ............ 0
      parent_frag ............ (none)
      fragment_type .......... master
      xn_access_mode ......... read_only
      auto_query_retry ....... enabled
      embedded_arkcmp ........ used
      select_list ............ %(0)
      input_variables ........ %(0), %(0), %(0)
    
    VALUES ====================================  SEQ_NO 1    NO CHILDREN
    DESCRIPTION
      fragment_id ............ 0
      parent_frag ............ (none)
      fragment_type .......... master
      tuple_expr ............. %(0)
    
    --- SQL operation complete.
    >>

----


> add a new explain option to mask variant fields in output
> ---------------------------------------------------------
>
>                 Key: TRAFODION-2683
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-2683
>             Project: Apache Trafodion
>          Issue Type: Improvement
>            Reporter: Anoop Sharma
>            Assignee: Anoop Sharma
>            Priority: Minor
>
> Full explain returns detailed information about a query plan which is very 
> useful in
> determining if the chosen plan is as expected and other details about it.
> But returned output contains information that may vary from run to run, or 
> from one
> system to another, or may be data dependent, and so on.
> Some examples are UIDs, or cost/memory estimates, or number of cpus/nodes, 
> etc.
> Currently these variations are handled by checking in the new expected files 
> (bad idea),
> or creating known diff files, or adding filters, or selecting specific fields 
> from explain virtual
> table, or just not using explain.
> This jira proposes a new option which when specified, will filter and mask 
> fields that
> are variant and change.
> The option is called 'c' (cleanse) and could be specified as part
> of explain "options '<str>' " clause. It works with both full explain and 
> formatted explain.
>  
> This option is useful when running regressions where one need to validate 
> enhancements
> and other changes that do not involve costing/estimates/dop etc related 
> values.
> This option should not be used when those values are important. 
> For ex, if a scan is expected to return 100 rows and explain need to show 
> that, or
> if a query should use 4 esps, then using the 'c' option will mask it. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to