[ 
https://issues.apache.org/jira/browse/TRAFODION-2821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16269099#comment-16269099
 ] 

ASF GitHub Bot commented on TRAFODION-2821:
-------------------------------------------

Github user DaveBirdsall commented on a diff in the pull request:

    
https://github.com/apache/incubator-trafodion/pull/1314#discussion_r153564680
  
    --- Diff: core/sql/executor/OrcFileReader.cpp ---
    @@ -111,9 +133,15 @@ OFR_RetCode OrcFileReader::init()
     //    JavaMethods_[JM_FETCHBUFF2].jm_signature = "(II)[Ljava/lang/String;";
         JavaMethods_[JM_CLOSE     ].jm_name      = "close";
         JavaMethods_[JM_CLOSE     ].jm_signature = "()Ljava/lang/String;";
    -   
    -    return (OFR_RetCode)JavaObjectInterface::init(className, javaClass_, 
JavaMethods_, (Int32)JM_LAST, FALSE);
    +    
    +    lv_retcode = (OFR_RetCode)JavaObjectInterface::init(className,
    +                                                   javaClass_,
    +                                                   JavaMethods_,
    +                                                   (Int32)JM_LAST, 
javaMethodsInitialized_);
    +    javaMethodsInitialized_ = TRUE;
    --- End diff --
    
    Nit. This should be "true" instead of "TRUE" since this is a bool instead 
of an NABoolean. But it's an unobservable bug.


> Trafodion core code base needs to be thread safe 
> -------------------------------------------------
>
>                 Key: TRAFODION-2821
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-2821
>             Project: Apache Trafodion
>          Issue Type: Improvement
>          Components: sql-general
>    Affects Versions: any
>            Reporter: Selvaganesan Govindarajan
>            Assignee: Selvaganesan Govindarajan
>             Fix For: 2.3-incubating
>
>
> This is the covering trafodion jira to make trafodion core code base to be 
> thread safe. It is needed to ensure that type T2 JDBC driver hosted on 
> platform can be enabled to support multi-threaded JDBC applications.
> [TRAFODION-2783] is one such case.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to