sfwang218 commented on PR #152: URL: https://github.com/apache/incubator-uniffle/pull/152#issuecomment-1210065492
> Em....if we remove the app after we judge whether the event is valid, some app resource still won't be deleted. I feel that this pr don't solve the problems totally. In this case, there two situations: 1. We judge the event is valid and the 'write' method is finished, and then we remove the app. In this way, the app resource will be deleted cleanly 2. We judge the event is valid and the 'write' method is not finished, and then we remove the app. In this way, the 'write' method will throw exception, and will retry later as shown below  when the event retry, we will judge whether it is valid again as shown below  In summary, i think this pr can solve the problems totally, I don't know if I'm right, Please correct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
