jerqi commented on code in PR #148:
URL: https://github.com/apache/incubator-uniffle/pull/148#discussion_r941962994
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/SimpleClusterManager.java:
##########
@@ -99,6 +101,13 @@ void nodesCheck() {
}
}
}
+ if (!deleteIds.isEmpty() || outputAliveServerCount % 30 == 0) {
+ LOG.info("Alive servers number: {}, ids: {}",
Review Comment:
Why do you judge `deleteIds.isEmpty()`?
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/CoordinatorConf.java:
##########
@@ -47,6 +47,12 @@ public class CoordinatorConf extends RssBaseConf {
.longType()
.defaultValue(30 * 1000L)
.withDescription("timeout if can't get heartbeat from shuffle server");
+ public static final ConfigOption<Long>
COORDINATOR_NODES_PERIODIC_OUTPUT_INTERVAL_TIMES = ConfigOptions
+ .key("rss.coordinator.server.periodic.output.interval.times")
+ .longType()
Review Comment:
Could we add `checkValue`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
