jerqi commented on code in PR #150:
URL: https://github.com/apache/incubator-uniffle/pull/150#discussion_r947381091
##########
common/src/main/java/org/apache/uniffle/common/metrics/GRPCMetrics.java:
##########
@@ -25,6 +25,13 @@
import io.prometheus.client.Gauge;
public abstract class GRPCMetrics {
+ // Grpc server internal executor metrics
+ public static final String GRPC_SERVER_EXECUTOR_ACTIVE_THREADS_TAG =
"grpcServerExecutorActiveThreads";
Review Comment:
`TAG` is too general, I feel it's a little inappropriate, could we give it a
better name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
