jerqi commented on code in PR #159:
URL: https://github.com/apache/incubator-uniffle/pull/159#discussion_r948611146
##########
internal-client/src/main/java/org/apache/uniffle/client/impl/grpc/ShuffleServerGrpcClient.java:
##########
@@ -290,10 +278,22 @@ public RssSendShuffleDataResponse
sendShuffleData(RssSendShuffleDataRequest requ
return response;
}
- private SendShuffleDataResponse doSendData(SendShuffleDataRequest
rpcRequest) {
+ private SendShuffleDataResponse doSendData(String appId, int size,
RssSendShuffleDataRequest request,
Review Comment:
Method `doXXXXX` usually have one rpc operation. Could we encapsulate the
behavior in the other places?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
