jerqi commented on code in PR #168:
URL: https://github.com/apache/incubator-uniffle/pull/168#discussion_r950950957
##########
server/src/main/java/org/apache/uniffle/server/storage/HdfsStorageManager.java:
##########
@@ -108,13 +114,25 @@ public void registerRemoteStorage(String appId,
RemoteStorageInfo remoteStorageI
appIdToStorages.putIfAbsent(appId, pathToStorages.get(remoteStorage));
}
- private HdfsStorage getStorageByAppId(String appId) {
+ public HdfsStorage getStorageByAppId(String appId) {
if (!appIdToStorages.containsKey(appId)) {
- String msg = "Can't find HDFS storage for appId[" + appId + "]";
- LOG.error(msg);
- // outside should deal with null situation
Review Comment:
Why do we remove the comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
