izchen opened a new pull request, #174:
URL: https://github.com/apache/incubator-uniffle/pull/174

   ### What changes were proposed in this pull request?
   Use `org.apache.spark.TaskContext#addTaskCompletionListener` to clean up 
resources used by `RssShuffleDataIterator`. This avoids possible resource leaks.
   
   
   ### Why are the changes needed?
   Before this PR, `RssShuffleDataIterator` would only clean up used resources 
after all records read.
   
   When the `Task` fails or cancels, or runs some special logic such as 
`LocalLimit`, the resource will not be cleaned up. This creates potential 
resource leaks.
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   Added a UT case


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to